Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🩹 Minor integration test and comment fixes (and testing Blacksmith runners) #380

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

ffarall
Copy link
Contributor

@ffarall ffarall commented Feb 24, 2025

This PR:

  • Solves minor race condition in integration tests.
  • Changes items in doc comments to use -.
  • Was used to test Blacksmith test runners.

cache: false
- name: Run sccache-cache
uses: mozilla-actions/[email protected]
- uses: rui314/setup-mold@v1
Copy link
Contributor

@undercover-cactus undercover-cactus Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid security issue we should avoid using github actions written by individuals or unknown organizations.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mozilla is pretty well known entity, as is the mold action. Industry standard some would say

@ffarall ffarall changed the title ci: 👷 Use blacksmith runners for GH actions fix: 🩹 Minor integration test and comment fixes (and testing Blacksmith runners) Feb 28, 2025
@ffarall ffarall marked this pull request as ready for review February 28, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants